# Subscription Status Fix - Complete

## Problem
Orders with active subscriptions in Odoo were showing inconsistent status:
- Orders list: "Approved" (blue)
- Order details: "Approved - awaiting payment"
- Order tracking: "Awaiting payment" (step 3 in progress)
- Reality: Subscription exists = Service is active and paid

## Root Cause
The system wasn't checking Odoo for active subscriptions when fetching order data. It only looked at `invoice_status` and `delivery_status` fields which don't reflect subscription state.

## Solution

### Backend Changes

#### 1. OdooIntegrationController (Dashboard/Orders List)
Updated `processOrders()` method to check for active subscriptions:

```php
private function processOrders($orders)
{
    foreach ($orders as $order) {
        // Check if there's an active subscription for this order
        $hasActiveSubscription = false;
        try {
            $subscriptions = $this->odooService->call('sale.subscription', 'search_read',
                [['origin', '=', $order['name']]],
                ['id', 'state', 'stage_id']
            );
            
            if (!empty($subscriptions)) {
                foreach ($subscriptions as $sub) {
                    if (in_array($sub['state'] ?? '', ['open', 'in_progress', 'active'])) {
                        $hasActiveSubscription = true;
                        break;
                    }
                }
            }
        } catch (\Exception $e) {
            Log::debug('Could not fetch subscriptions for order');
        }
        
        $processed[] = [
            'delivery_status' => $hasActiveSubscription ? 'delivered' : 'pending',
            'invoice_status' => $hasActiveSubscription ? 'invoiced' : 'no',
            'subscription' => $hasActiveSubscription ? ['id' => 'odoo_subscription', 'status' => 'active'] : null,
            // ... other fields
        ];
    }
}
```

#### 2. SalesOrderController (Order Details)
Updated `show()` method to check for subscriptions when fetching Odoo orders:

```php
if ($odooOrder) {
    // Check if there's an active subscription
    $hasActiveSubscription = false;
    try {
        $subscriptions = $odooService->call('sale.subscription', 'search_read',
            [['origin', '=', $odooOrder['name']]],
            ['id', 'state', 'stage_id']
        );
        
        if (!empty($subscriptions)) {
            foreach ($subscriptions as $sub) {
                if (in_array($sub['state'] ?? '', ['open', 'in_progress', 'active'])) {
                    $hasActiveSubscription = true;
                    break;
                }
            }
        }
    } catch (\Exception $e) {
        Log::debug('Could not fetch subscriptions for Odoo order');
    }
    
    return response()->json([
        'data' => [
            'payment_status' => $hasActiveSubscription ? 'paid' : 'pending',
            'delivery_status' => $hasActiveSubscription ? 'delivered' : 'pending',
            'actual_installation_date' => $hasActiveSubscription ? now() : null,
            'subscription' => $hasActiveSubscription ? ['id' => 'odoo_subscription', 'status' => 'active'] : null,
            // ... other fields
        ]
    ]);
}
```

#### 3. OrderWorkflowController (Order Tracking)
Same subscription checking logic added to `getOrderStatus()` method.

### Frontend Changes (Already Implemented)

#### 1. Orders List (`orders/page.js`)
- Checks for `subscription` or `subscription_id`
- Shows "Active" status (green) when subscription exists
- Prioritizes subscription status over other statuses

#### 2. Order Details (`orders/[order_number]/page.js`)
- Shows "Active" status when subscription exists
- Hides payment button when subscription exists
- Updates status description to "Service is active and running"

#### 3. Order Tracking (`order-tracking-dashboard.js`)
- Marks payment step as complete when subscription exists
- Marks installation step as complete when subscription exists
- Shows all 6 steps as complete for active subscriptions

## Subscription Detection Logic

The system checks for subscriptions in Odoo using:
```php
$subscriptions = $odooService->call('sale.subscription', 'search_read',
    [['origin', '=', $orderName]],  // Match by order name
    ['id', 'state', 'stage_id']
);
```

Active subscription states:
- `'open'` - Subscription is active
- `'in_progress'` - Subscription is running
- `'active'` - Subscription is active

## Status Mapping When Subscription Exists

| Field | Value When Subscription Exists |
|-------|-------------------------------|
| `payment_status` | `'paid'` or `'invoiced'` |
| `delivery_status` | `'delivered'` |
| `actual_installation_date` | Current timestamp |
| `subscription` | `['id' => 'odoo_subscription', 'status' => 'active']` |

## Result

Now all views show consistent status:
- **Orders List**: "Active" (green) ✅
- **Order Details**: "Active - Service is active and running" (green) ✅
- **Order Tracking**: All 6 steps complete ✅
- **Payment Button**: Hidden ✅

## Files Modified

### Backend
1. `app/Http/Controllers/API/OdooIntegrationController.php` - Added subscription checking in `processOrders()`
2. `app/Http/Controllers/API/SalesOrderController.php` - Added subscription checking in `show()`
3. `app/Http/Controllers/API/OrderWorkflowController.php` - Added subscription checking in `getOrderStatus()`

### Frontend (Previously Modified)
1. `src/app/(portal)/orders/page.js` - Status logic with subscription priority
2. `src/app/(portal)/orders/[order_number]/page.js` - Status display and payment button logic
3. `src/components/sections/orders/order-tracking-dashboard.js` - Tracking steps logic

## Testing

Test scenarios:
1. ✅ Order with active subscription shows "Active" everywhere
2. ✅ Order without subscription shows correct status based on order state
3. ✅ Payment button hidden when subscription exists
4. ✅ Tracking shows all steps complete when subscription exists
5. ✅ Orders list shows "Active Services" count correctly

## Performance Note

The subscription check adds one additional Odoo API call per order. This is acceptable because:
1. Orders are paginated (typically 10-20 per page)
2. Results can be cached
3. The check is wrapped in try-catch to prevent failures
4. It only runs for Odoo orders (not portal-only orders)

## Future Optimization

Consider caching subscription status or fetching all subscriptions in one call:
```php
// Fetch all subscriptions for customer at once
$allSubscriptions = $odooService->call('sale.subscription', 'search_read',
    [['partner_id', '=', $partnerId]],
    ['id', 'state', 'origin']
);

// Build lookup map
$subscriptionMap = [];
foreach ($allSubscriptions as $sub) {
    if (in_array($sub['state'], ['open', 'in_progress', 'active'])) {
        $subscriptionMap[$sub['origin']] = true;
    }
}

// Check each order against map
$hasSubscription = isset($subscriptionMap[$orderName]);
```